Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rendering tests that are failing on GitHub actions #2480

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 13, 2024

🦟 Bug fix

Summary

Follow-up to #2477, see #2477 (review). With xvfb enabled, more rendering tests are run and some of them are failing. This PR disables the failing tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner July 13, 2024 00:45
@iche033 iche033 mentioned this pull request Jul 13, 2024
@iche033 iche033 changed the title Disable tests that are failing on GitHub actions Disable rendering tests that are failing on GitHub actions Jul 13, 2024
@iche033 iche033 merged commit 335e363 into merge_6_7_20240712 Jul 16, 2024
6 checks passed
@iche033 iche033 deleted the disable_test_github branch July 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants