Check if any entity actually has a ContactSensorData component before… #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calling GetContactsFromLastStep Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
iche033
reviewed
Jul 12, 2024
Signed-off-by: Shameek Ganguly <[email protected]>
iche033
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… calling GetContactsFromLastStep
GetContactsFromLastStepcan be an expensive call if there are a lot of contact points in the scene. Currently we call this method in the Physics System when the ECM has theContactSensorDatacomponent type. However, this will still be true if theContactSensorDatacomponent has been removed for all entities.I have updated the Physics System to additionally check if there is at least one entity with the
ContactSensorDatacomponent before callingGetContactsFromLastStep. This enables consuming Systems to optimize their computational footprint by only adding theContactSensorDatafor relevant entities when needed and remove it when not needed.Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.