Do not update sensors if it a triggered sensor #2443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Depends on gazebosim/gz-sensors#441
Summary
Currently the logic for checking active sensors ignores the triggered property of a camera. So as the result, when you subscribe to any triggered sensors, they become "active" (added to the
activeSensors
list) and they perform unnecessary prerender updates even when they don't have pending triggers. This PR adds a check for the triggered property of the sensor to filter them out when checking for active sensors.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.