Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Empty Test File #2396

Merged
merged 2 commits into from
May 6, 2024
Merged

Remove Empty Test File #2396

merged 2 commits into from
May 6, 2024

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented May 6, 2024

🦟 Bug fix

Fixes #

Summary

The test in this file does nothing. We should remove it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

The test in this file does nothing. We should remove it.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from mjcarroll as a code owner May 6, 2024 02:45
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 6, 2024
@arjo129 arjo129 enabled auto-merge (squash) May 6, 2024 09:56
@arjo129
Copy link
Contributor Author

arjo129 commented May 6, 2024

Not sure why the ABI checker is complaining. I dont think this test affects any public api.

@arjo129 arjo129 merged commit 6af7445 into gz-sim8 May 6, 2024
8 of 9 checks passed
@arjo129 arjo129 deleted the arjo/refactor/remove_unused_file branch May 6, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants