Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardPort #2388 Fix unused gcc warnings #2395

Merged
merged 1 commit into from
May 3, 2024

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented May 2, 2024

🦟 Bug fix

Fixes gcc warnings appearing in CI:
https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/66/gcc/

Summary

Forward port to fix warnings on main

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 2, 2024
@Blast545 Blast545 changed the base branch from gz-sim8 to main May 2, 2024 23:12
@Blast545 Blast545 mentioned this pull request May 2, 2024
@Blast545 Blast545 self-assigned this May 2, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.94%. Comparing base (098085b) to head (6dfb9ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   65.95%   65.94%   -0.01%     
==========================================
  Files         327      327              
  Lines       31319    31318       -1     
==========================================
- Hits        20655    20654       -1     
  Misses      10664    10664              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 9e45959 into main May 3, 2024
9 of 12 checks passed
@azeey azeey deleted the blast545/fp_2388_fix_unused_gcc_warn branch May 3, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants