[Backport]: Fix ModelPhotoShootTest test failures (#2294) #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failures are caused by a change in the DART physics engine (dartsim/dart#1774) which causes joints to recover after reaching or exceeding their position limits. It seems like the model used in this plugin starts off with joint limits violated and recovers after a few iterations. This causes a small movement of the robot. Since the test works by comparing images taken of the robot at the start of simulation and after a few iterations, the small movement causes a discrepancy in the images. The solution here is to run the whole test while simulation is paused. This also cleans up some TestFixture warnings. Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
approved these changes
Mar 19, 2024
iche033
previously approved these changes
Mar 19, 2024
|
looks like the |
|
I think the failures were related to Fuel server outages. @osrf-jenkins run tests please |
Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port
Backporting #2294
Note to maintainers: Remember to Rebase and merge with commit