Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error in the tunnel.sdf file has been corrected #2264

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

serkanMzlm
Copy link
Contributor

@serkanMzlm serkanMzlm commented Dec 12, 2023

The light on top of the vehicle was facing the wrong direction; this issue has been corrected

🦟 Bug fix

The light on top of the vehicle in the tunnel.sdf file was illuminating the left side of the vehicle. This has been corrected, and now the light illuminates the front of the vehicle.

Summary

The light on top of the vehicle in the tunnel.sdf file was illuminating the left side of the vehicle. This has been corrected, and now the light illuminates the front of the vehicle.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

The light on top of the vehicle was facing the wrong direction; this issue has been corrected

Signed-off-by: Serkan Mazlum <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a88340b) 64.72% compared to head (0bc8a0d) 64.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim7    #2264      +/-   ##
===========================================
+ Coverage    64.72%   64.77%   +0.04%     
===========================================
  Files          357      357              
  Lines        29140    29140              
===========================================
+ Hits         18860    18874      +14     
+ Misses       10280    10266      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

examples/worlds/tunnel.sdf Outdated Show resolved Hide resolved
The light direction has been specified

Signed-off-by: Serkan Mazlum <[email protected]>
@azeey azeey merged commit 8ec622d into gazebosim:gz-sim7 Dec 13, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants