Add support for writing systems in Python #2045
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
This allows multiple PythonSystemLoaders to run albeit with a single python interpreter. Signed-off-by: Addisu Z. Taddese <[email protected]>
…nto python_systems
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
ahcorde
requested changes
Jul 21, 2023
| @@ -0,0 +1,23 @@ | |||
| from gz.sim8 import UpdateInfo, EntityComponentManager, Model | |||
Comment on lines
+20
to
+23
| <world name="python_system"> | ||
|
|
||
|
|
||
| <light type="directional" name="sun"> |
There was a problem hiding this comment.
Suggested change
| <world name="python_system"> | |
| <light type="directional" name="sun"> | |
| <world name="python_system"> | |
| <light type="directional" name="sun"> |
| @@ -22,11 +22,15 @@ | |||
| #include <gz/msgs/server_control.pb.h> | |||
| #include <gz/msgs/stringmsg_v.pb.h> | |||
|
|
|||
|
|
|||
Comment on lines
+61
to
+62
| gzerr << "Error while loading module 'sys'\n" | ||
| << _err.what() << std::endl; |
There was a problem hiding this comment.
Suggested change
| gzerr << "Error while loading module 'sys'\n" | |
| << _err.what() << std::endl; | |
| gzerr << "Error while loading module 'sys'\n" | |
| << _err.what() << std::endl; |
Voldivh
reviewed
Jul 21, 2023
| @@ -22,11 +22,15 @@ | |||
| #include <gz/msgs/server_control.pb.h> | |||
| #include <gz/msgs/stringmsg_v.pb.h> | |||
|
|
|||
|
|
|||
| { | ||
| _method(std::forward<Args>(_args)...); | ||
| } | ||
| catch (const pybind11::error_already_set &_err) |
There was a problem hiding this comment.
Suggested change
| catch (const pybind11::error_already_set &_err) | |
| catch (const py::error_already_set &_err) |
Yes, I have an example with some instructions. |
Voldivh
reviewed
Jul 25, 2023
| // TODO (azeey) Improve formatting. | ||
| gzdbg << py::str(searchPaths).cast<std::string>() << std::endl; | ||
| } | ||
| catch (const pybind11::error_already_set &_err) |
There was a problem hiding this comment.
Suggested change
| catch (const pybind11::error_already_set &_err) | |
| catch (const py::error_already_set &_err) |
Voldivh
reviewed
Jul 25, 2023
| { | ||
| this->pythonModule = py::module_::import(moduleName.c_str()); | ||
| } | ||
| catch (const pybind11::error_already_set &_err) |
There was a problem hiding this comment.
Suggested change
| catch (const pybind11::error_already_set &_err) | |
| catch (const py::error_already_set &_err) |
Voldivh
reviewed
Jul 25, 2023
| } | ||
| this->pythonSystem = getSystem(); | ||
| } | ||
| catch (const pybind11::error_already_set &_err) |
There was a problem hiding this comment.
Suggested change
| catch (const pybind11::error_already_set &_err) | |
| catch (const py::error_already_set &_err) |
Voldivh
force-pushed
the
voldivh/python_bindings_model
branch
from
7bf6366
to
30439ab
Compare
Voldivh
force-pushed
the
voldivh/python_bindings_model
branch
2 times, most recently
from
7998bf7
to
af115a1
Compare
|
It seems that github automatically closed this PR because the branch it was targeting was deleted. I'm also not able to reopen it, so I'll create a new PR. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #790
Summary
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.