Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bindings for the Link convenience class #2039

Merged
merged 34 commits into from
Aug 16, 2023
Merged

Adds bindings for the Link convenience class #2039

merged 34 commits into from
Aug 16, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Jul 19, 2023

🎉 New feature

Summary

This PR creates the python bindings for the Link convenience class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Voldivh
Use alias on bindings
df9608e 
Signed-off-by: Voldivh <[email protected]>
@Voldivh Voldivh changed the title Adds python bindings to the Link convenience class Adds bindings to the Link convenience class Jul 19, 2023
@Voldivh Voldivh changed the title Adds bindings to the Link convenience class Adds bindings for the Link convenience class Jul 19, 2023
@Voldivh Voldivh marked this pull request as ready for review July 19, 2023 20:12
@Voldivh Voldivh requested a review from mjcarroll as a code owner July 19, 2023 20:12
ahcorde
ahcorde previously requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
Base automatically changed from nkoenig/7-to-main to main July 20, 2023 18:06
@Voldivh Voldivh force-pushed the voldivh/python_bindings_link branch from c195b28 to 2f84163 Compare July 26, 2023 15:35
@Voldivh Voldivh requested a review from mabelzhang as a code owner July 26, 2023 15:35
@Voldivh Voldivh changed the base branch from main to voldivh/python_bindings_model July 26, 2023 15:36
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #2039 (3aef77f) into main (5e40cb8) will decrease coverage by 0.01%.
The diff coverage is 51.19%.

❗ Current head 3aef77f differs from pull request most recent head cb3f6d7. Consider uploading reports for the commit cb3f6d7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
- Coverage   65.46%   65.46%   -0.01%     
==========================================
  Files         314      315       +1     
  Lines       29814    29898      +84     
==========================================
+ Hits        19519    19572      +53     
- Misses      10295    10326      +31
Files Changed Coverage Δ
python/src/gz/sim/Link.cc 50.60% <50.60%> (ø)
python/src/gz/sim/_gz_sim_pybind11.cc 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from b8f644f to 7998bf7 Compare August 1, 2023 18:00
@Voldivh Voldivh force-pushed the voldivh/python_bindings_link branch from e4ad18f to 922a5c7 Compare August 1, 2023 18:04
Voldivh and others added 4 commits August 8, 2023 10:31
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from 7998bf7 to af115a1 Compare August 8, 2023 15:47
@Voldivh Voldivh force-pushed the voldivh/python_bindings_link branch from 7c0ca37 to 10d00fc Compare August 8, 2023 15:54
Base automatically changed from voldivh/python_bindings_model to main August 12, 2023 05:39
azeey
azeey approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor issues.

python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Link.cc Outdated Show resolved Hide resolved
python/test/link_TEST.py Outdated Show resolved Hide resolved
@azeey azeey requested a review from ahcorde August 16, 2023 01:44
@azeey azeey dismissed ahcorde’s stale review August 16, 2023 16:08

Comments have been resolved

@azeey azeey merged commit e9e2fca into main Aug 16, 2023
4 checks passed
@azeey azeey deleted the voldivh/python_bindings_link branch August 16, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voldivh @azeey @ahcorde @mjcarroll