Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bindings for the model convenience class #2036

Merged
merged 24 commits into from
Aug 12, 2023
Merged

Adds bindings for the model convenience class #2036

merged 24 commits into from
Aug 12, 2023

Conversation

Voldivh
Copy link
Contributor

@Voldivh Voldivh commented Jul 18, 2023 •
edited
Loading

🎉 New feature

Summary

This PR creates the python bindings for the Model convenience class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #2036 (21fd553) into main (aef0335) will decrease coverage by 0.03%.
The diff coverage is 51.85%.

❗ Current head 21fd553 differs from pull request most recent head 5f0a2bf. Consider uploading reports for the commit 5f0a2bf to get more accurate results

@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   65.53%   65.50%   -0.03%     
==========================================
  Files         313      314       +1     
  Lines       29742    29796      +54     
==========================================
+ Hits        19490    19517      +27     
- Misses      10252    10279      +27
Files Changed Coverage Δ
python/src/gz/sim/World.cc 50.00% <42.85%> (-3.66%) ⬇️
python/src/gz/sim/Model.cc 51.11% <51.11%> (ø)
python/src/gz/sim/_gz_sim_pybind11.cc 100.00% <100.00%> (ø)

@Voldivh
Use alias on bindings
df9608e 
Signed-off-by: Voldivh <[email protected]>
@Voldivh Voldivh changed the title Adds model bindings Adds bindings for the model convenience class Jul 19, 2023
@Voldivh Voldivh marked this pull request as ready for review July 19, 2023 20:12
@Voldivh Voldivh requested a review from mjcarroll as a code owner July 19, 2023 20:12
ahcorde
ahcorde requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests ?

python/src/gz/sim/Model.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Model.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Model.cc Outdated Show resolved Hide resolved
python/src/gz/sim/Model.cc Outdated Show resolved Hide resolved
Base automatically changed from nkoenig/7-to-main to main July 20, 2023 18:06
@Voldivh Voldivh changed the base branch from main to voldivh/python_bindings_world July 26, 2023 15:28
@Voldivh Voldivh requested a review from mabelzhang as a code owner July 26, 2023 15:28
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from 7bf6366 to 30439ab Compare July 26, 2023 15:29
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from b8f644f to 7998bf7 Compare August 1, 2023 18:00
@Voldivh Voldivh force-pushed the voldivh/python_bindings_model branch from 7998bf7 to af115a1 Compare August 8, 2023 15:47
Base automatically changed from voldivh/python_bindings_world to main August 8, 2023 21:54
azeey
azeey reviewed Aug 9, 2023
View reviewed changes
python/src/gz/sim/Model.cc Show resolved Hide resolved
python/test/model_TEST.py Outdated Show resolved Hide resolved
python/test/model_test.sdf Show resolved Hide resolved
python/test/model_TEST.py Outdated Show resolved Hide resolved
azeey
azeey reviewed Aug 10, 2023
View reviewed changes
python/test/model_TEST.py Outdated Show resolved Hide resolved
azeey
azeey approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one change about kNullEntity.

@azeey azeey merged commit f18626e into main Aug 12, 2023
4 of 6 checks passed
@azeey azeey deleted the voldivh/python_bindings_model branch August 12, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde requested changes

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

@mabelzhang mabelzhang Awaiting requested review from mabelzhang

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voldivh @azeey @ahcorde @mjcarroll