-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Apply Link Wrench system #1593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
the
MBARI buoy
Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
label
Jul 14, 2022
This was referenced Jul 14, 2022
Signed-off-by: Louise Poubel <[email protected]>
9 tasks
chapulina
added
the
needs upstream release
Blocked by a release of an upstream library
label
Jul 15, 2022
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
changed the base branch from
ign-gazebo3
to
chapulina/3/entity_from_msg
July 15, 2022 16:45
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
removed
the
needs upstream release
Blocked by a release of an upstream library
label
Jul 19, 2022
Signed-off-by: Louise Poubel <[email protected]>
quarkytale
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
(Nit the apply wrench on box command in the description has "type" missing, fixed it)
Signed-off-by: Louise Poubel <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏰 citadel
Ignition Citadel
MBARI buoy
Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
I needed a convenient way of applying forces to models without a plugin, so I thought I'd add a system that exposes a topic for applying wrenches to links.
The idea is similar to Gazebo classic's
~/scoped/link/name/wrench
topic, but here there's a single topic for the entire world, and the exact entity is defined in the message. This way, we don't pollute the topic space, allow different ways of choosing entities (by ID, by type, etc), and don't need to instantiate the plugin for each entity.I needed to add a few different things to implement this plugin. I'll break this into smaller PRs for each functionality, adding tests as needed.
Test it
Try the example world:
With example commands, i.e.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸