Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trajectory follower: enable WorldPose component #1382

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The TrajectoryFollower's example world doesn't work out of the box on Garden. The WorldPose component needs to be explicitly enabled for it to work. I didn't look into why that's different from Fortress, but most likely some other plugin was enabling that component.

Now the example works:

trajectory_follower_2

By the way, this would have been caught more easily on the forward-port if there were a test for the plugin. As mentioned in #1332 (comment), we should add one. CC @caguero @iche033

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the bug Something isn't working label Mar 10, 2022
@chapulina chapulina requested a review from caguero March 10, 2022 19:19
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1382 (4d8b91f) into main (3969f5b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files         300      300           
  Lines       24106    24106           
=======================================
  Hits        15203    15203           
  Misses       8903     8903           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3969f5b...4d8b91f. Read the comment docs.

@caguero
Copy link
Contributor

caguero commented Mar 10, 2022

Thanks for the fix!

@chapulina chapulina merged commit fc9cadd into main Mar 10, 2022
@chapulina chapulina deleted the chapulina/7/traj_follower branch March 10, 2022 22:31
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants