-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable joint state publisher's topic #1076
Merged
chapulina
merged 3 commits into
gazebosim:ign-gazebo5
from
jasmeet0915:configurable_joint_state_topic
Nov 15, 2021
Merged
Configurable joint state publisher's topic #1076
chapulina
merged 3 commits into
gazebosim:ign-gazebo5
from
jasmeet0915:configurable_joint_state_topic
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Oct 1, 2021
Signed-off-by: Jasmeet Singh <[email protected]>
…rror Signed-off-by: Jasmeet Singh <[email protected]>
Signed-off-by: Jasmeet Singh <[email protected]>
jasmeet0915
force-pushed
the
configurable_joint_state_topic
branch
from
November 15, 2021 21:46
5105afb
to
281f1c3
Compare
chapulina
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating!
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Jasmeet Singh <[email protected]> Signed-off-by: William Lew <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
ijnek
added a commit
to ijnek/gz-sim
that referenced
this pull request
Aug 28, 2022
Adding some API docs for changes from gazebosim#1076
8 tasks
ijnek
added a commit
to ijnek/gz-sim
that referenced
this pull request
Aug 28, 2022
Adding some API docs for changes from gazebosim#1076 Signed-off-by: Kenji Brameld <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Aug 29, 2022
Adding some API docs for changes from #1076 Signed-off-by: Kenji Brameld <[email protected]>
traversaro
pushed a commit
to traversaro/ign-gazebo
that referenced
this pull request
Oct 19, 2022
Adding some API docs for changes from gazebosim#1076 Signed-off-by: Kenji Brameld <[email protected]> Signed-off-by: Silvio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #1057
Summary
Makes the topic for JointStatePublisher configurable
Expected behavior:
A user should be able to provide a topic for JointStatePublisher using
<topic>
in the sdfTest it
<topic>
tags.ign topic -l
and you are able to echo it usingign topic -t $your_topic_name -e
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge