Fix rotating cubes when placed by GUI tool while using the buoyancy plugin

[arjo129]

🦟 Bug fix

Fixes #

Summary

Previously @aaronchongth discovered that the following behaviour takes place when adding shapes using the GUI tool while running the simulation

done.mp4

While this makes for great VFX, it is certainly not intended behavior. The root cause was eventually traced to the fact that when the gui tool is used new objects don't have a pose. The buoyancy plugin creates a pose component but does not wait for an update cycle. This PR moves the point at which the pose is read. Thus in the first preupdate cycle, the plugin will do nothing but enable the pose component.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note

If you test this in the fortress demo world you may find the cubes sink really slowly. This is fine, as the cubes are really light given their volume and the plugin is configured to simulate air.

[codecov]

Codecov Report

Merging #1064 (a5eb1f2) into main (57f672d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
- Coverage   64.08%   64.01%   -0.07%     
==========================================
  Files         255      255              
  Lines       19917    19919       +2     
==========================================
- Hits        12763    12752      -11     
- Misses       7154     7167      +13     

Impacted Files	Coverage Δ
src/systems/buoyancy/Buoyancy.cc	82.53% <100.00%> (+0.18%)	⬆️
...int_position_controller/JointPositionController.cc	53.14% <0.00%> (-7.43%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f672d...a5eb1f2. Read the comment docs.