Skip to content

Commit

Permalink
Fix more broken references
Browse files Browse the repository at this point in the history
Signed-off-by: methylDragon <[email protected]>
  • Loading branch information
methylDragon committed May 20, 2022
1 parent 949c253 commit b7de1b3
Show file tree
Hide file tree
Showing 20 changed files with 49 additions and 49 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ else()
endif()
endif()
# Plugin install dirs
set(IGNITION_GAZEBO_PLUGIN_INSTALL_DIR
set(GZ_SIM_PLUGIN_INSTALL_DIR
${CMAKE_INSTALL_PREFIX}/${IGN_LIB_INSTALL_DIR}/ign-${IGN_DESIGNATION}-${PROJECT_VERSION_MAJOR}/plugins
)
set(IGNITION_GAZEBO_GUI_PLUGIN_INSTALL_DIR
set(GZ_SIM_GUI_PLUGIN_INSTALL_DIR
${CMAKE_INSTALL_PREFIX}/${IGN_LIB_INSTALL_DIR}/ign-${IGN_DESIGNATION}-${PROJECT_VERSION_MAJOR}/plugins/gui
)

Expand Down
4 changes: 2 additions & 2 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2699,7 +2699,7 @@

### Gazebo 2.18.0 (2020-05-20)

1. Added a `/world/<world_name>/create_multiple` service that parallels the current `/world/<world_name>/create` service. The `create_multiple` service can handle an `ignition::msgs::EntityFactory_V` message that may contain one or more entities to spawn.
1. Added a `/world/<world_name>/create_multiple` service that parallels the current `/world/<world_name>/create` service. The `create_multiple` service can handle an `gz::msgs::EntityFactory_V` message that may contain one or more entities to spawn.
* [Pull Request 146](https://github.com/gazebosim/gz-sim/pull/146)

1. DetachableJoint system: Add option to suppress warning about missing child model
Expand Down Expand Up @@ -3116,7 +3116,7 @@
1. Update Camera and DepthCamera components to use sdf::Sensor object instead of an sdf::ElementPtr.
* [BitBucket pull request 299](https://osrf-migration.github.io/ignition-gh-pages/#!/gazebosim/gz-sim/pull-requests/299)

1. Added system for ignition::sensors::AirPressureSensor.
1. Added system for gz::sensors::AirPressureSensor.
* [BitBucket pull request 300](https://osrf-migration.github.io/ignition-gh-pages/#!/gazebosim/gz-sim/pull-requests/300)

1. Support conversion and serialization of Imu components. IMU sensors are
Expand Down
18 changes: 9 additions & 9 deletions Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ since pose information is being logged in the `changed_state` topic.

* Use `cli` component of `ignition-utils1`.

* `ignition::sim::RenderUtil::SelectedEntities()` now returns a
* `gz::sim::RenderUtil::SelectedEntities()` now returns a
`const std::vector<Entity> &` instead of forcing a copy. The calling code
should create a copy if it needs to modify the vector in some way.

Expand All @@ -109,14 +109,14 @@ since pose information is being logged in the `changed_state` topic.

* Various `GuiEvent`s were deprecated in favor of their Gazebo GUI
equivalents.
* **Deprecated** `ignition::sim::gui::SnapIntervals`
* **Replacement** `ignition::gui::SnapIntervals`
* **Deprecated** `ignition::sim::gui::Render`
* **Replacement** `ignition::gui::Render`
* **Deprecated** `ignition::sim::gui::SpawnPreviewModel`
* **Replacement** `ignition::gui::SpawnFromDescription`
* **Deprecated** `ignition::sim::gui::SnapPreviewPath`
* **Replacement** `ignition::gui::SnapFromPath`
* **Deprecated** `gz::sim::gui::SnapIntervals`
* **Replacement** `gz::gui::SnapIntervals`
* **Deprecated** `gz::sim::gui::Render`
* **Replacement** `gz::gui::Render`
* **Deprecated** `gz::sim::gui::SpawnPreviewModel`
* **Replacement** `gz::gui::SpawnFromDescription`
* **Deprecated** `gz::sim::gui::SnapPreviewPath`
* **Replacement** `gz::gui::SnapFromPath`

* The `<direction>` tag of spot lights was previously not parsed by the
scene, so all spot lights shone in the direction corresponding to the
Expand Down
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ add_dependencies(${PROJECT_LIBRARY_TARGET_NAME}
gz-sim_private_msgs
)

set(IGNITION_GAZEBO_PLUGIN_INSTALL_DIR
set(GZ_SIM_PLUGIN_INSTALL_DIR
${CMAKE_INSTALL_PREFIX}/${IGN_LIB_INSTALL_DIR}/ign-${IGN_DESIGNATION}-${PROJECT_VERSION_MAJOR}/plugins
)

Expand Down
4 changes: 2 additions & 2 deletions src/ServerPrivate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ struct LoggingPlugin
public: static std::string &LoggingPluginFileName()
{
static std::string recordPluginFileName =
std::string("ignition-gazebo") +
IGNITION_GAZEBO_MAJOR_VERSION_STR + "-log-system";
std::string("gz-sim") +
GZ_SIM_MAJOR_VERSION_STR + "-log-system";
return recordPluginFileName;
}

Expand Down
2 changes: 1 addition & 1 deletion src/SystemLoader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class gz::sim::SystemLoaderPrivate
std::string homePath;
gz::common::env(IGN_HOMEDIR, homePath);
systemPaths.AddPluginPaths(homePath + "/.gz/sim/plugins");
systemPaths.AddPluginPaths(IGN_GAZEBO_PLUGIN_INSTALL_DIR);
systemPaths.AddPluginPaths(GZ_SIM_PLUGIN_INSTALL_DIR);

auto pathToLib = systemPaths.FindSharedLibrary(_filename);
if (pathToLib.empty())
Expand Down
2 changes: 1 addition & 1 deletion src/SystemLoader_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ TEST(SystemLoader, Constructor)
root.LoadSdfString(std::string("<?xml version='1.0'?><sdf version='1.6'>"
"<world name='default'>"
"<plugin filename='libignition-gazebo") +
IGNITION_GAZEBO_MAJOR_VERSION_STR + "-physics-system.so' "
GZ_SIM_MAJOR_VERSION_STR + "-physics-system.so' "
"name='gz::sim::systems::Physics'></plugin>"
"</world></sdf>");

Expand Down
2 changes: 1 addition & 1 deletion src/Util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ std::string resolveSdfWorldFile(const std::string &_sdfFile,
systemPaths.SetFilePathEnv(kResourcePathEnv);

// Worlds installed with ign-gazebo
systemPaths.AddFilePaths(IGN_GAZEBO_WORLD_INSTALL_DIR);
systemPaths.AddFilePaths(GZ_SIM_WORLD_INSTALL_DIR);

filePath = systemPaths.FindFile(_sdfFile);
}
Expand Down
18 changes: 9 additions & 9 deletions src/cmd/ign.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@
//////////////////////////////////////////////////
extern "C" char *ignitionGazeboVersion()
{
return strdup(GZ_GAZEBO_VERSION_FULL);
return strdup(GZ_SIM_VERSION_FULL);
}

//////////////////////////////////////////////////
extern "C" char *gazeboVersionHeader()
{
return strdup(IGNITION_GAZEBO_VERSION_HEADER);
return strdup(GZ_SIM_VERSION_HEADER);
}

//////////////////////////////////////////////////
Expand All @@ -52,7 +52,7 @@ extern "C" void cmdVerbosity(
//////////////////////////////////////////////////
extern "C" const char *worldInstallDir()
{
return IGN_GAZEBO_WORLD_INSTALL_DIR;
return GZ_SIM_WORLD_INSTALL_DIR;
}

//////////////////////////////////////////////////
Expand Down Expand Up @@ -145,7 +145,7 @@ extern "C" int runServer(const char *_sdfString,

serverConfig.SetLogRecordPath(recordPathMod);

ignmsg << "Ignition Gazebo Server v" << GZ_GAZEBO_VERSION_FULL
ignmsg << "Ignition Gazebo Server v" << GZ_SIM_VERSION_FULL
<< std::endl;

// Set the SDF string to user
Expand Down Expand Up @@ -214,24 +214,24 @@ extern "C" int runGui(const char *_guiConfig)
sigKilled = true;
});

ignmsg << "Ignition Gazebo GUI v" << GZ_GAZEBO_VERSION_FULL
ignmsg << "Ignition Gazebo GUI v" << GZ_SIM_VERSION_FULL
<< std::endl;

int argc = 0;
char **argv = nullptr;

// Initialize Qt app
gz::gui::Application app(argc, argv);
app.AddPluginPath(IGN_GAZEBO_GUI_PLUGIN_INSTALL_DIR);
app.AddPluginPath(GZ_SIM_WORLD_INSTALL_DIR;;

// add import path so we can load custom modules
app.Engine()->addImportPath(IGN_GAZEBO_GUI_PLUGIN_INSTALL_DIR);
app.Engine()->addImportPath(GZ_SIM_WORLD_INSTALL_DIR;;

// Set default config file for Gazebo
std::string defaultConfigDir;
gz::common::env(IGN_HOMEDIR, defaultConfigDir);
defaultConfigDir = gz::common::joinPaths(defaultConfig, ".gz",
"sim", IGNITION_GAZEBO_MAJOR_VERSION_STR);
"sim", GZ_SIM_MAJOR_VERSION_STR);

auto defaultConfig = gz::common::joinPaths(defaultConfigDir,
"gui.config");
Expand Down Expand Up @@ -406,7 +406,7 @@ extern "C" int runGui(const char *_guiConfig)
if (!gz::common::exists(defaultConfig))
{
auto installedConfig = gz::common::joinPaths(
IGNITION_GAZEBO_GUI_CONFIG_PATH, "gui.config");
GZ_SIM_GUI_CONFIG_PATH, "gui.config");

if (!gz::common::createDirectories(defaultConfigDir))
{
Expand Down
2 changes: 1 addition & 1 deletion src/gui/AboutDialogHandler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ using namespace sim::gui;
/////////////////////////////////////////////////
AboutDialogHandler::AboutDialogHandler()
{
aboutText += std::string(IGNITION_GAZEBO_VERSION_HEADER);
aboutText += std::string(GZ_SIM_VERSION_HEADER);
aboutText += "<table class='nostyle'>"
"<tr>"
"<td style='padding-right: 10px;'>Documentation:"
Expand Down
8 changes: 4 additions & 4 deletions src/gui/Gui.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ std::unique_ptr<gz::gui::Application> createGui(
sigKilled = true;
});

ignmsg << "Gazebo GUI v" << GZ_GAZEBO_VERSION_FULL
ignmsg << "Gazebo GUI v" << GZ_SIM_VERSION_FULL
<< std::endl;

// Set auto scaling factor for HiDPI displays
Expand All @@ -63,7 +63,7 @@ std::unique_ptr<gz::gui::Application> createGui(

// Initialize Qt app
auto app = std::make_unique<gz::gui::Application>(_argc, _argv);
app->AddPluginPath(IGN_GAZEBO_GUI_PLUGIN_INSTALL_DIR);
app->AddPluginPath(GZ_SIM_GUI_PLUGIN_INSTALL_DIR);

auto aboutDialogHandler = new gz::sim::gui::AboutDialogHandler();
aboutDialogHandler->setParent(app->Engine());
Expand All @@ -75,7 +75,7 @@ std::unique_ptr<gz::gui::Application> createGui(
pathManager->setParent(app->Engine());

// add import path so we can load custom modules
app->Engine()->addImportPath(IGN_GAZEBO_GUI_PLUGIN_INSTALL_DIR);
app->Engine()->addImportPath(GZ_SIM_GUI_PLUGIN_INSTALL_DIR);
std::string defaultGuiConfigName = "gui.config";

// Set default config file for Gazebo
Expand Down Expand Up @@ -280,7 +280,7 @@ std::unique_ptr<gz::gui::Application> createGui(
}

auto installedConfig = gz::common::joinPaths(
IGNITION_GAZEBO_GUI_CONFIG_PATH, defaultGuiConfigName);
GZ_SIM_GUI_CONFIG_PATH, defaultGuiConfigName);
if (!gz::common::exists(installedConfig))
{
ignerr << "Failed to copy installed config [" << installedConfig
Expand Down
2 changes: 1 addition & 1 deletion src/gui/plugins/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function(gz_add_gui_plugin plugin_name)
endif()
endif()

install (TARGETS ${plugin_name} DESTINATION ${IGNITION_GAZEBO_GUI_PLUGIN_INSTALL_DIR})
install (TARGETS ${plugin_name} DESTINATION ${GZ_SIM_GUI_PLUGIN_INSTALL_DIR})
endfunction()

add_subdirectory(modules)
Expand Down
4 changes: 2 additions & 2 deletions src/gui/plugins/modules/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ gz_add_gui_library(EntityContextMenu
QT_HEADERS EntityContextMenu.hh
)

install (TARGETS EntityContextMenu DESTINATION ${IGNITION_GAZEBO_GUI_PLUGIN_INSTALL_DIR}/${module_name})
install (FILES qmldir DESTINATION ${IGNITION_GAZEBO_GUI_PLUGIN_INSTALL_DIR}/${module_name})
install (TARGETS EntityContextMenu DESTINATION ${GZ_SIM_GUI_PLUGIN_INSTALL_DIR}/${module_name})
install (FILES qmldir DESTINATION ${GZ_SIM_GUI_PLUGIN_INSTALL_DIR}/${module_name})

4 changes: 2 additions & 2 deletions src/ign.cc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ extern "C" char *ignitionGazeboVersion()
//////////////////////////////////////////////////
extern "C" char *gazeboVersionHeader()
{
return strdup(IGNITION_GAZEBO_VERSION_HEADER);
return strdup(GZ_SIM_VERSION_HEADER);
}

//////////////////////////////////////////////////
Expand All @@ -56,7 +56,7 @@ extern "C" void cmdVerbosity(
//////////////////////////////////////////////////
extern "C" const char *worldInstallDir()
{
return IGN_GAZEBO_WORLD_INSTALL_DIR;
return GZ_SIM_WORLD_INSTALL_DIR;
}

//////////////////////////////////////////////////
Expand Down
4 changes: 2 additions & 2 deletions src/systems/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function(gz_add_system system_name)
endif()

# Note that plugins are currently being installed in 2 places. /lib and the plugin dir
install(TARGETS ${system_target} DESTINATION ${IGNITION_GAZEBO_PLUGIN_INSTALL_DIR})
install(TARGETS ${system_target} DESTINATION ${GZ_SIM_PLUGIN_INSTALL_DIR})

# The library created by `ign_add_component` includes the ign-gazebo version
# (i.e. libignition-gazebo1-name-system.so), but for portability of SDF
Expand All @@ -89,7 +89,7 @@ function(gz_add_system system_name)
else()
file(MAKE_DIRECTORY "${PROJECT_BINARY_DIR}/lib")
EXECUTE_PROCESS(COMMAND ${CMAKE_COMMAND} -E create_symlink ${versioned} ${unversioned} WORKING_DIRECTORY "${PROJECT_BINARY_DIR}/lib")
INSTALL(FILES ${PROJECT_BINARY_DIR}/lib/${unversioned} DESTINATION ${IGNITION_GAZEBO_PLUGIN_INSTALL_DIR})
INSTALL(FILES ${PROJECT_BINARY_DIR}/lib/${unversioned} DESTINATION ${GZ_SIM_PLUGIN_INSTALL_DIR})
endif()
endfunction()

Expand Down
2 changes: 1 addition & 1 deletion src/systems/physics/EntityFeatureMap_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class EntityFeatureMapFixture: public InternalFixture<::testing::Test>
const std::string pluginLib = "libignition-physics-dartsim-plugin.so";

common::SystemPaths systemPaths;
systemPaths.AddPluginPaths({IGNITION_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});

auto pathToLib = systemPaths.FindSharedLibrary(pluginLib);
ASSERT_FALSE(pathToLib.empty())
Expand Down
2 changes: 1 addition & 1 deletion src/systems/physics/Physics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ void Physics::Configure(const Entity &_entity,
// * Engines installed with ign-physics
common::SystemPaths systemPaths;
systemPaths.SetPluginPathEnv(this->dataPtr->pluginPathEnv);
systemPaths.AddPluginPaths({IGNITION_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});

auto pathToLib = systemPaths.FindSharedLibrary(pluginLib);
if (pathToLib.empty())
Expand Down
8 changes: 4 additions & 4 deletions test/integration/examples_build.cc
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ std::vector<ExampleEntry> GetExamples()
common::joinPaths(PROJECT_SOURCE_PATH, "/examples/", type);

// Iterate over directory
ignition::common::DirIter endIter;
for (ignition::common::DirIter dirIter(examplesDir);
gz::common::DirIter endIter;
for (gz::common::DirIter dirIter(examplesDir);
dirIter != endIter; ++dirIter)
{
auto base = ignition::common::basename(*dirIter);
auto base = gz::common::basename(*dirIter);
auto sourceDir = common::joinPaths(examplesDir, base);
examples.push_back({ type, base, sourceDir });
}
Expand Down Expand Up @@ -122,7 +122,7 @@ void ExamplesBuild::Build(const ExampleEntry &_entry)
}

// Path to examples of the given type
ASSERT_TRUE(ignition::common::exists(_entry.sourceDir));
ASSERT_TRUE(gz::common::exists(_entry.sourceDir));

igndbg << "Source: " << _entry.sourceDir << std::endl;

Expand Down
2 changes: 1 addition & 1 deletion test/integration/tracked_vehicle_system.cc
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class TrackedVehicleTest : public InternalFixture<::testing::Test>
// modifications)
common::SystemPaths systemPaths;
systemPaths.SetPluginPathEnv("GZ_SIM_PHYSICS_ENGINE_PATH");
systemPaths.AddPluginPaths({IGNITION_PHYSICS_ENGINE_INSTALL_DIR});
systemPaths.AddPluginPaths({GZ_PHYSICS_ENGINE_INSTALL_DIR});

auto pathToLib = systemPaths.FindSharedLibrary(*pluginLib);
ASSERT_FALSE(pathToLib.empty())
Expand Down
4 changes: 2 additions & 2 deletions test/test_config.hh.in
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ struct TestWorldSansPhysics
"<sdf version='1.6'>"
"<world name='default'>"
"<plugin filename='libignition-gazebo") +
GZ_GAZEBO_MAJOR_VERSION_STR + "-scene-broadcaster-system.so'"
GZ_SIM_MAJOR_VERSION_STR + "-scene-broadcaster-system.so'"
" name='gz::sim::systems::SceneBroadcaster'>"
"</plugin>"
"<plugin"
" filename='libignition-gazebo" +
GZ_GAZEBO_MAJOR_VERSION_STR + "-user-commands-system.so'"
GZ_SIM_MAJOR_VERSION_STR + "-user-commands-system.so'"
" name='gz::sim::systems::UserCommands'>"
"</plugin>"
"</world>"
Expand Down

0 comments on commit b7de1b3

Please sign in to comment.