Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minor comments to BaseGizmoVisual #881

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add minor comments to BaseGizmoVisual #881

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9248be5
add comments
iche033 Aug 15, 2023
a798757
Merge branch 'ign-rendering3' into gizmo_visual_enum
iche033 Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/gz/rendering/base/BaseGizmoVisual.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,8 @@ namespace ignition
this->visuals[TransformAxis::TA_TRANSLATION_X] = transXVis;
this->visuals[TransformAxis::TA_TRANSLATION_Y] = transYVis;
this->visuals[TransformAxis::TA_TRANSLATION_Z] = transZVis;
// Store the translation origin visual in this->visuals using a key
azeey marked this conversation as resolved.
Show resolved Hide resolved
// that's not already occupied by the TransformAxis enum
this->visuals[TransformAxis::TA_TRANSLATION_Z << 1] = transOrigin;

// translation handles
Expand Down Expand Up @@ -584,6 +586,8 @@ namespace ignition
this->visuals[TransformAxis::TA_ROTATION_X] = rotXVis;
this->visuals[TransformAxis::TA_ROTATION_Y] = rotYVis;
this->visuals[TransformAxis::TA_ROTATION_Z] = rotZVis;
// Store the full rotation visual in this->visuals using a key
// that's not already occupied by the TransformAxis enum
this->visuals[TransformAxis::TA_ROTATION_Z << 1] = rotFullVis;

// rotation handles
Expand Down
Loading