Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide optix related cmake warnings #1032

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Hide optix related cmake warnings #1032

merged 2 commits into from
Aug 12, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 7, 2024

🦟 Bug fix

Summary

Hide optix and cuda related cmake warnings. Given that we're not actively maintaining the optix plugin, these warnings are distracting and may be misleading to users so hide them. In the future, let's consider archiving / removing the optix plugin.

Hides these warnings if cuda and optix are not available on your system:

CUDA_TOOLKIT_ROOT_DIR not found or specified
CMake Warning at /home/iche/code/gz_i_ws/install/share/cmake/gz-cmake4/cmake4/GzConfigureBuild.cmake:59 (message):
   CONFIGURATION WARNINGS:
   -- Missing dependency [OptiX]
Call Stack (most recent call first):
  CMakeLists.txt:219 (gz_configure_build)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 7, 2024
@iche033 iche033 merged commit c3f3e2c into main Aug 12, 2024
6 of 8 checks passed
@iche033 iche033 deleted the silence_optix_warnings branch August 12, 2024 23:16
@scpeters
Copy link
Member

I believe this has introduced a new cmake warning, which I was attempting to fix in gazebo-tooling/release-tools#1161

CMake Warning:
  Manually-specified variables were not used by the project:

    SKIP_optix

but that change to release-tools affects all branches. I can try adding some version logic to it actually...

@iche033
Copy link
Contributor Author

iche033 commented Aug 14, 2024

ok thanks. The idea here is that to avoid building optix by default without having users to explicitly specify the SKIP_optix flags on ionic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants