Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ogre2 ray query related functions to return Ogre::MovableObject instead of Ogre::Item #1024

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 26, 2024

🎉 New feature

Summary

Addresses one of the todo items.

Ray query related functions in ogre2 now return Ogre::MovableObject instead of Ogre::Item (Ogre::Item is derived from Ogre::MovableObject). This is so that we can include heightmap ogre objects (which are Ogre::MovableObject typed objects) in the ray query results.

2 API changes are documented in the Migration guide. One of them (OnSelectionClick()) is a change to the return type so it can not be deprecated, i.e. API breaking change.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 26, 2024
@iche033 iche033 merged commit e4a61fb into main Jul 29, 2024
6 of 8 checks passed
@iche033 iche033 deleted the rayquery_api_ogre2 branch July 29, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants