Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials/09_use_custom_engine: Add actual build&run instructions #689

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 16, 2024

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#1428

Summary

The tutorial included wrong instructions for building the example. This PR fixes that.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

tutorials/09_use_custom_engine.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (b181d63) to head (1a02224).
Report is 8 commits behind head on gz-physics8.

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics8     #689   +/-   ##
============================================
  Coverage        79.44%   79.44%           
============================================
  Files              144      144           
  Lines             8646     8646           
============================================
  Hits              6869     6869           
  Misses            1777     1777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor

azeey commented Sep 16, 2024

Looks like there are some CI issues, but I'll go ahead and merge this since it's only updating documentation.

@azeey azeey merged commit 615afd9 into gazebosim:gz-physics8 Sep 16, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-physics: Use a custom engine with Gazebo Physics
4 participants