Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable test failing due to ODE/libccd #621

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Apr 8, 2024

🦟 Bug fix

Part of #620.

Summary

As noted in #620, the JointFeaturesDetachTest/0.JointDetach test has been failing on macOS since ODE 0.16.5 was merged to homebrew-core in Homebrew/homebrew-core#167158. This disables the failing test expectations while we investigate the cause in #620.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of #620.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Apr 8, 2024
@scpeters scpeters merged commit 4e400e0 into gz-physics7 Apr 9, 2024
9 checks passed
@scpeters scpeters deleted the scpeters/ode_libccd_test_disable branch April 9, 2024 01:14
scpeters added a commit that referenced this pull request Apr 20, 2024
@scpeters scpeters mentioned this pull request Apr 20, 2024
8 tasks
scpeters added a commit that referenced this pull request Apr 22, 2024
Blast545 added a commit that referenced this pull request May 20, 2024
scpeters pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants