Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bazel updates for garden" #596

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

mjcarroll
Copy link
Contributor

Reverts #513

@mjcarroll mjcarroll self-assigned this Feb 6, 2024
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 6, 2024
@scpeters
Copy link
Member

scpeters commented Feb 6, 2024

can you sign off on the commit?

This reverts commit 1016539.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll force-pushed the revert-513-mjcarroll/garden_bazel branch from 96273c1 to a429376 Compare February 6, 2024 19:53
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4fa59f2) 78.59% compared to head (a429376) 78.52%.
Report is 5 commits behind head on gz-physics6.

Files Patch % Lines
dartsim/src/GzOdeCollisionDetector.cc 82.85% 6 Missing ⚠️
dartsim/src/WorldFeatures.cc 83.33% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           gz-physics6     #596      +/-   ##
===============================================
- Coverage        78.59%   78.52%   -0.08%     
===============================================
  Files              140      140              
  Lines             7654     7670      +16     
===============================================
+ Hits              6016     6023       +7     
- Misses            1638     1647       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll
Copy link
Contributor Author

can you sign off on the commit?

Done

@scpeters scpeters merged commit ea90ada into gz-physics6 Feb 6, 2024
9 of 11 checks passed
@scpeters scpeters deleted the revert-513-mjcarroll/garden_bazel branch February 6, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants