Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Set collision spinning friction #579

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 7, 2023

🦟 Bug fix

Summary

Set collision spinning friction using on sdf's torsional coefficient value. If not specified in sdf, the default value of 1.0 is used.

When 2 boxes penetrate, bullet pushes them apart. Without the spinning friction set, the boxes will continue to spin indefinitely or until it collides with another object. This PR sets the spinning friction to prevent this from happening

Before:
bullet_no_spinning_friction

After:
bullet_spinning_friction

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (af58fa5) 78.68% compared to head (c98cbdf) 78.59%.

Files Patch % Lines
bullet-featherstone/src/SDFFeatures.cc 58.33% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           gz-physics6     #579      +/-   ##
===============================================
- Coverage        78.68%   78.59%   -0.09%     
===============================================
  Files              140      140              
  Lines             7648     7654       +6     
===============================================
- Hits              6018     6016       -2     
- Misses            1630     1638       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 5b74d1f into gz-physics6 Dec 7, 2023
12 of 16 checks passed
@iche033 iche033 deleted the bullet_spinning_friction branch December 7, 2023 21:35
@iche033 iche033 added the Bullet Bullet engine label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants