-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Apache license version #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM but this should target ign-physics3
Codecov Report
@@ Coverage Diff @@
## ign-physics5 #325 +/- ##
=============================================
Coverage 75.73% 75.73%
=============================================
Files 129 129
Lines 5762 5762
=============================================
Hits 4364 4364
Misses 1398 1398 Continue to review full report at Codecov.
|
Why? I found them while doing a code review of |
Please refer to our contribution guidelines: "Pull requests should target the lowest possible supported version where the changes can be added in a backwards-compatible way (no API / ABI / behavior break in released branches)." If that's too much of a hassle for you, we can backport the PR after it's merged though. You'll still need to sign your commit for the DCO checker though, thanks! |
Signed-off-by: Jochen Sprickerhof <[email protected]>
51769ae
to
da23424
Compare
Please refer to our [contribution guidelines](https://ignitionrobotics.org/docs/all/contributing#process):
"_Pull requests should target the lowest possible supported version where the changes can be added in a backwards-compatible way (no API / ABI / behavior break in released branches)._"
That sounds uncommon, you may want to revisit how other projects doing
it, i.e. backporting the changes.
If that's too much of a hassle for you, we can backport the PR after it's merged though.
Please do, for example `dartsim/src/WorldFeatures_TEST.cc` is not in
ign-physics3, so I would need to fill more then one PR?
You'll still need to sign your commit for the DCO checker though, thanks!
Done.
|
Signed-off-by: Jochen Sprickerhof <[email protected]>
Signed-off-by: Jochen Sprickerhof <[email protected]>
Signed-off-by: Jochen Sprickerhof <[email protected]> Co-authored-by: Jochen Sprickerhof <[email protected]>
Signed-off-by: Jochen Sprickerhof <[email protected]> Co-authored-by: Jochen Sprickerhof <[email protected]>
No description provided.