Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apache license version #325

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

jspricke
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 12, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but this should target ign-physics3

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #325 (da23424) into ign-physics5 (abd7c45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-physics5     #325   +/-   ##
=============================================
  Coverage         75.73%   75.73%           
=============================================
  Files               129      129           
  Lines              5762     5762           
=============================================
  Hits               4364     4364           
  Misses             1398     1398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd7c45...da23424. Read the comment docs.

@jspricke
Copy link
Contributor Author

this should target ign-physics3

Why? I found them while doing a code review of ign-physics5 for Debian. Also 5 is your default branch.

@chapulina
Copy link
Contributor

this should target ign-physics3
Why?

Please refer to our contribution guidelines:

"Pull requests should target the lowest possible supported version where the changes can be added in a backwards-compatible way (no API / ABI / behavior break in released branches)."

If that's too much of a hassle for you, we can backport the PR after it's merged though.

You'll still need to sign your commit for the DCO checker though, thanks!

Signed-off-by: Jochen Sprickerhof <[email protected]>
@jspricke
Copy link
Contributor Author

jspricke commented Jan 12, 2022 via email

@scpeters scpeters merged commit 95e36b0 into gazebosim:ign-physics5 Jan 24, 2022
scpeters pushed a commit to scpeters/ign-physics that referenced this pull request Jan 24, 2022
scpeters pushed a commit to scpeters/ign-physics that referenced this pull request Jan 24, 2022
chapulina pushed a commit that referenced this pull request Jan 24, 2022
Signed-off-by: Jochen Sprickerhof <[email protected]>

Co-authored-by: Jochen Sprickerhof <[email protected]>
scpeters added a commit that referenced this pull request Jan 25, 2022
Signed-off-by: Jochen Sprickerhof <[email protected]>

Co-authored-by: Jochen Sprickerhof <[email protected]>
@scpeters scpeters mentioned this pull request Jun 29, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants