-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tutorial snippets with new Doxygen filters #316
Conversation
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 75.54% 75.54%
=======================================
Files 127 127
Lines 5655 5655
=======================================
Hits 4272 4272
Misses 1383 1383 Continue to review full report at Codecov.
|
Garden will stay on |
Took a look at the version table. Making a note here. Since all of C-F use ign-cmake2, the only backporting needed would be #312 and this PR to ign-physics2 (Citadel), 4 (Edifice) if backporting prior to 2022-03, and 5 (Fortress). |
Signed-off-by: Mabel Zhang <[email protected]>
Yup, for completeness, I'll just mention that a backport PR can be open for Citadel, and then Edifice and Fortress will get the fixes as Citadel is merged forward. |
Signed-off-by: Mabel Zhang <[email protected]>
🦟 Bug fix
Followup of #312
Depends on gazebosim/gz-cmake#198
Summary
With gazebosim/gz-cmake#198 , now the snippets in tutorials 5, 7, 8 show up correctly.
Recompile
(Is it okay for this PR to target
ign-physics
main
and that one toign-cmake2
? The tutorials are only fixed onmain
and not Garden. Can backport toign-physics5
if needed.)Navigate to those 3 tutorials from the local page, and check that the snippets to
CMakeLists.txt
,dartsim/*/.cc
, anddartsim/*/.hh
are showing:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.