Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to harmonic #32

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Migrate to harmonic #32

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 26, 2024

🎉 New feature

Closes #

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Sep 26, 2024
Copy link

@shameekganguly shameekganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alejandro!

- This code will only run on Linux (for now).
- You should [install Ignition Fortress](https://ignitionrobotics.org/docs/fortress) (from source).

**Requirements**:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the updated README is focused solely on Omniverse connectors. Would it make sense to preserve some of the Gazebo-related documentation such as requirements?

@gabrielfpacheco
Copy link

Hi @ahcorde, thank you for looking into providing support for Gazebo Harmonic! Do you know if there are any plans to continue this work?

@ahcorde
Copy link
Contributor Author

ahcorde commented Nov 6, 2024

Hi @ahcorde, thank you for looking into providing support for Gazebo Harmonic! Do you know if there are any plans to continue this work?

The API has changed a lot, I don't have time right now to dedicate to this. But I would be able to review PRs if you want to open it

@ahcorde ahcorde marked this pull request as draft November 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants