Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to build python version of protos #474

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 7, 2024

🎉 New feature

Depends on gazebosim/gz-bazel#77

Summary

Add rule in bazel build file to build python version of proto files

Test it

Setup up gz-bazel worksspace, update to update_rules_python_version branch (see gazebosim/gz-bazel#77) and build:

bazel build //msgs/...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from caguero as a code owner November 7, 2024 00:43
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 7, 2024
@iche033 iche033 changed the title build python proto Add rule to build python version of protos Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (1939fb0) to head (d8a094b).
Report is 14 commits behind head on gz-msgs10.

Additional details and impacted files
@@              Coverage Diff              @@
##           gz-msgs10     #474      +/-   ##
=============================================
+ Coverage      98.19%   98.21%   +0.01%     
=============================================
  Files             27       27              
  Lines           1166     1174       +8     
=============================================
+ Hits            1145     1153       +8     
  Misses            21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit ba58722 into gz-msgs10 Nov 7, 2024
14 checks passed
@iche033 iche033 deleted the python_proto branch November 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants