Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in generator plugin code #404

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Use a managed pointer rather than a raw pointer to ensure that cleanup happens correctly.

Discovered with asan.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #404 (89d1040) into gz-msgs10 (edd9632) will not change coverage.
Report is 1 commits behind head on gz-msgs10.
The diff coverage is 100.00%.

❗ Current head 89d1040 differs from pull request most recent head dae88a1. Consider uploading reports for the commit dae88a1 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #404   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1172     1172           
==========================================
  Hits            1140     1140           
  Misses            32       32           
Files Coverage Δ
core/generator/Generator.cc 92.64% <100.00%> (ø)

@mjcarroll mjcarroll merged commit 8021595 into gz-msgs10 Oct 30, 2023
14 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/generator_memory_leak branch October 30, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants