Generate messages in downstream builds #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
* Split into MessageFactory, which is a non-static variant, should help with any potential ODR issues down the road * Refactor Factory to just be wrapper around a message factory singleton * Remove filesystem.hh * General cleanups Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
…carroll/split_factory
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
5 tasks
ahcorde
requested changes
May 11, 2023
| # OUTPUT_CPP_HH_VAR - A CMake variable name containing a list that the C++ header path should be appended to | ||
| # OUTPUT_CPP_CC_VAR - A Cmake variable name containing a list that the C++ source path should be appended to | ||
| # Multi value arguments | ||
| # INPUT_PROTOS - Passed to protoc --proto_path |
Comment on lines
+54
to
+57
| endforeach() | ||
|
|
||
|
|
||
| set(GENERATE_ARGS |
There was a problem hiding this comment.
Suggested change
| endforeach() | |
| set(GENERATE_ARGS | |
| endforeach() | |
| set(GENERATE_ARGS |
Comment on lines
+68
to
+69
| DEPENDS | ||
| ${depends_index} |
There was a problem hiding this comment.
style
Suggested change
| DEPENDS | |
| ${depends_index} | |
| DEPENDS ${depends_index} |
| # PROTOC_EXEC - Path to protoc | ||
| # INPUT_PROTO - Path to the input .proto file | ||
| # OUTPUT_CPP_DIR - Path where C++ files are saved | ||
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ header path should be appended to |
There was a problem hiding this comment.
Suggested change
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ header path should be appended to | |
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ include path should be appended to |
| # PROTOC_EXEC - Path to protoc | ||
| # INPUT_PROTO - Path to the input .proto file | ||
| # OUTPUT_CPP_DIR - Path where C++ files are saved | ||
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ header path should be appended to |
There was a problem hiding this comment.
Suggested change
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ header path should be appended to | |
| # OUTPUT_INCLUDES - A CMake variable name containing a list that the C++ include path should be appended to |
| @@ -0,0 +1,87 @@ | |||
| /* | |||
| * Copyright (C) 2016 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2016 Open Source Robotics Foundation | |
| * Copyright (C) 2023 Open Source Robotics Foundation |
| @@ -0,0 +1,61 @@ | |||
| /* | |||
| * Copyright (C) 2016 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2016 Open Source Robotics Foundation | |
| * Copyright (C) 2023 Open Source Robotics Foundation |
| @@ -0,0 +1,107 @@ | |||
| /* | |||
| * Copyright (C) 2016 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (C) 2016 Open Source Robotics Foundation | |
| * Copyright (C) 2023 Open Source Robotics Foundation |
| add_subdirectory(integration) | ||
| add_subdirectory(performance) | ||
| add_subdirectory(regression) | ||
| #add_subdirectory(gtest_vendor) |
| @@ -0,0 +1,165 @@ | |||
| #!/usr/bin/env python3 | |||
| # | |||
| # Copyright (C) 2022 Open Source Robotics Foundation | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2022 Open Source Robotics Foundation | |
| # Copyright (C) 2023 Open Source Robotics Foundation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of how message generation works. Instead of generating source/headers from proto files as part of building the gz-msgs package, it will instead install scripts and cmake helper functions to allow downstream packages to generate messages as part of their builds.
An example of a downstream package utilizing this: https://github.com/mjcarroll/mjcarroll-custom-msgs
This is a placeholder PR (keeping in draft) so that I can clean my changes up and get feedback.