Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Stopwatch test #610

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jul 17, 2024

🦟 Bug fix

Summary

Adds a small sleep between starting the timer and querying the elapsed time to avoid flakiness.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@scpeters scpeters merged commit 0925141 into gazebosim:main Jul 17, 2024
10 checks passed
@azeey azeey deleted the fix_stopwatch_flake branch July 17, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants