Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove APIs deprecated in gz-math7 #601

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 1, 2024

🎉 New feature

Removes deprecated functionality

Summary

These APIs have been deprecated since the Garden release, so we can remove them.

This is a draft pull request targeting #600 to avoid conflicts with the Migration guide. I will mark it ready for review once that is merged.

Test it

Build an Ionic workspace with this branch and ensure it all compiles successfully.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Recommend using std::chrono::steady_clock directly
instead of this alias.

Fixes #436.

Signed-off-by: Steve Peters <[email protected]>
Base automatically changed from scpeters/deprecate_math_clock_alias to main July 2, 2024 13:29
@scpeters scpeters marked this pull request as ready for review July 2, 2024 19:54
@ahcorde ahcorde merged commit 1fd7435 into main Jul 4, 2024
9 checks passed
@ahcorde ahcorde deleted the scpeters/rm_deprecated_8 branch July 4, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants