Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port 6 to 7, 2023-03-14 #526

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Forward port 6 to 7, 2023-03-14 #526

merged 2 commits into from
Mar 14, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 14, 2023

➡️ Forward port

Port ign-math6 to gz-math7

Branch comparison: gz-math7...ign-math6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

* Custom PID error rate

Signed-off-by: Nate Koenig <[email protected]>

* added test

Signed-off-by: Nate Koenig <[email protected]>

---------

Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 14, 2023
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI !

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #526 (3946c6f) into gz-math7 (1e84669) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 3946c6f differs from pull request most recent head 29cbcb4. Consider uploading reports for the commit 29cbcb4 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #526   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7026     7031    +5     
=========================================
+ Hits           7005     7010    +5     
  Misses           21       21           
Impacted Files Coverage Δ
src/PID.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nkoenig nkoenig merged commit 85de00b into gz-math7 Mar 14, 2023
@nkoenig nkoenig deleted the nkoenig/6-to-7-20230314 branch March 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants