Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the python library as gz.math7 #503

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

Allow side-by-side installations of python bindings by renaming the library to include the version in the name. From ignition.math or gz.math to gz.math7.

Particularly, the current approach is causing problems since it conflicts with gz-math6 bindings since both install in ignition/math path in the filesystem. This is blocking the installation of Fortress + Garden side-by-side.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #503 (cbcb910) into gz-math7 (3f63e1f) will not change coverage.
The diff coverage is n/a.

❗ Current head cbcb910 differs from pull request most recent head 141c7b7. Consider uploading reports for the commit 141c7b7 to get more accurate results

@@            Coverage Diff            @@
##           gz-math7     #503   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

we'll need to make a prerelease after this is merged and update downstream python bindings in sdformat

@azeey azeey added the bug Something isn't working label Sep 15, 2022
Migration.md Outdated Show resolved Hide resolved
@j-rivero j-rivero merged commit a824223 into gz-math7 Sep 15, 2022
@j-rivero j-rivero deleted the jrivero/python_bindings_versioned branch September 15, 2022 15:52
j-rivero added a commit to gazebosim/sdformat that referenced this pull request Sep 15, 2022
Adapting the code to the change in gazebosim/gz-math#503
Signed-off-by: Jose Luis Rivero <[email protected]>
@peci1
Copy link
Contributor

peci1 commented Sep 20, 2022

It's definitely good to have the option to select the particular version. However, what is the maintenance plan for this? If there is no way for downstream code to use some convenience like import gz.math, maintaining 3rd-party (and even 1st-party) code would become a nightmare...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants