-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the python library as gz.math7 #503
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-math7 #503 +/- ##
=========================================
Coverage 99.70% 99.70%
=========================================
Files 77 77
Lines 7007 7007
=========================================
Hits 6986 6986
Misses 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
we'll need to make a prerelease after this is merged and update downstream python bindings in sdformat |
Co-authored-by: Addisu Z. Taddese <[email protected]>
Adapting the code to the change in gazebosim/gz-math#503 Signed-off-by: Jose Luis Rivero <[email protected]>
It's definitely good to have the option to select the particular version. However, what is the maintenance plan for this? If there is no way for downstream code to use some convenience like |
🦟 Bug fix
Summary
Allow side-by-side installations of python bindings by renaming the library to include the version in the name. From
ignition.math
orgz.math
togz.math7
.Particularly, the current approach is causing problems since it conflicts with
gz-math6
bindings since both install inignition/math
path in the filesystem. This is blocking the installation of Fortress + Garden side-by-side.Checklist
codecheck
passed (See contributing)