Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial update: macOS binary install #500

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 14, 2022

🦟 Bug fix

Fixes macOS binary install tutorial. Part of gazebosim/garden-tutorial-party#210

Summary

  • Update brew install command (see https://brew.sh )
  • Remove instructions about using ign-* for old formulae, since all current formulae have gz-* aliases.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

* Update brew install command
* Remove instructions about using ign-*
  for old formulae, since all current
  formulae have gz-* aliases.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters added the tutorial-party Use to indicate a PR is for a tutorial party, which is part of the Gazebo release process. label Sep 14, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #500 (e8964ea) into gz-math7 (860c546) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           gz-math7     #500   +/-   ##
=========================================
  Coverage     99.70%   99.70%           
=========================================
  Files            77       77           
  Lines          7007     7007           
=========================================
  Hits           6986     6986           
  Misses           21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

which version you need. From version 7 you should use `gz-math<#>` but for lower versions
you should use `ign-math<#>`.
Be sure to replace `<#>` with a number value, such as 6 or 7, depending on
which version you need.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is the same in MacOS ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we added gz-* aliases for all currently supported packages (dependencies of Citadel, Fortress and gazebo9) in osrf/homebrew-simulation#1984

@ahcorde ahcorde enabled auto-merge (squash) September 16, 2022 20:51
@scpeters scpeters merged commit 4a22946 into gz-math7 Sep 16, 2022
@scpeters scpeters deleted the scpeters/tutorial_install_macos_binary branch September 16, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tutorial-party Use to indicate a PR is for a tutorial party, which is part of the Gazebo release process.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants