Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolumetricGridLookupField: generalize index type, add constructor #475

Merged
merged 5 commits into from
Jul 28, 2022
Merged

VolumetricGridLookupField: generalize index type, add constructor #475

merged 5 commits into from
Jul 28, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Jul 27, 2022

This PR generifies the index term. It also adds a constructor which is used by #456.

Signed-off-by: Arjo Chakravarty [email protected]

@arjo129
Generify index and adds a new constructor
9a84ceb 
This PR generifies the index term. It also adds a constructor which is used by #456.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129
style
c8e7542 
Signed-off-by: Arjo Chakravarty <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 27, 2022
@arjo129 arjo129 mentioned this pull request Jul 27, 2022
Merged
9 tasks
@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #475 (dee59e4) into main (155059b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          75       75           
  Lines        6863     6888   +25     
=======================================
+ Hits         6842     6867   +25     
  Misses         21       21
Impacted Files Coverage Δ
include/gz/math/VolumetricGridLookupField.hh 96.38% <100.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155059b...dee59e4. Read the comment docs.

hidmic
hidmic approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are minor, LGTM

include/gz/math/VolumetricGridLookupField.hh Outdated Show resolved Hide resolved
src/VolumetricGridLookupField_TEST.cc Outdated Show resolved Hide resolved
@chapulina chapulina added the enhancement New feature or request label Jul 27, 2022
@scpeters scpeters changed the title Generify index and adds a new constructor VolumetricGridLookupField: generalize index type, add constructor Jul 28, 2022
@arjo129
Address Knits.
64e03b9 
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129
Merge branch 'arjo/feat/volumetric_grid_custom_constructor' of github…
dee59e4 
….com:gazebosim/gz-math into arjo/feat/volumetric_grid_custom_constructor
@arjo129 arjo129 enabled auto-merge July 28, 2022 02:55
@arjo129 arjo129 merged commit 3e7f04b into main Jul 28, 2022
@arjo129 arjo129 deleted the arjo/feat/volumetric_grid_custom_constructor branch July 28, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request 🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjo129 @hidmic @chapulina