Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated appendToStream - they're new on v7 #454

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

chapulina
Copy link
Contributor

Follow-up to

Summary

The appendToStream functions were added on main, so they don't need to be deprecated and can be removed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 6, 2022
@chapulina chapulina requested review from azeey and jennuine July 6, 2022 02:52
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #454 (ac5e949) into main (3827f4c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files          73       73              
  Lines        6639     6631       -8     
==========================================
- Hits         6618     6610       -8     
  Misses         21       21              
Impacted Files Coverage Δ
include/gz/math/Helpers.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3827f4c...ac5e949. Read the comment docs.

@chapulina chapulina self-assigned this Jul 6, 2022
@chapulina chapulina merged commit 34d481d into main Jul 6, 2022
@chapulina chapulina deleted the chapulina/7/appendToStream branch July 6, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants