-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce compilation time #433
Conversation
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 99.69% 99.69% -0.01%
==========================================
Files 73 73
Lines 6588 6567 -21
==========================================
- Hits 6568 6547 -21
Misses 20 20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/github/workspace/include/gz/math/Helpers.hh:588: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Noticed that
math
seemed really slow. Quick look and it seems like we were overusinginline
in theHelpers.hh
file.Between moving some of the
inlined
functions and pruning unneeded headers, we pick up about 30 seconds on my system.Before:
After: