Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MassMatrix3: fix bug in PrincipalAxesOffset tolerances #424

Merged
merged 5 commits into from
May 10, 2022
Merged

MassMatrix3: fix bug in PrincipalAxesOffset tolerances #424

merged 5 commits into from
May 10, 2022

Commits on May 6, 2022

  1. MassMatrix3: add test showing tolerance bug 

    There is an error in the way tolerances are computed
in the PrincipalAxesOffset API, and I've added a
more tests for the tolerance parameter to the
PrincipalAxes* APIs, which include failing test cases
to illustrate the bug.

Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed May 6, 2022
    Configuration menu
    Copy the full SHA
    3776a65 View commit details
    Browse the repository at this point in the history

  2. PrincipalAxesOffset: fix use of tolerance 

    The relative tolerance was not being used when calling
PrincipalMoments, so use it properly.

Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed May 6, 2022
    Configuration menu
    Copy the full SHA
    478ccf8 View commit details
    Browse the repository at this point in the history

  3. Add comments about new test expectations 

    Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed May 6, 2022
    Configuration menu
    Copy the full SHA
    40fe3c4 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Merge branch 'ign-math6' into mass_matrix3_tolerance_bug

    @scpeters
    scpeters authored May 9, 2022
    Configuration menu
    Copy the full SHA
    8dc8e93 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Add test case showing rotated size vector 

    Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed May 10, 2022
    Configuration menu
    Copy the full SHA
    31f4345 View commit details
    Browse the repository at this point in the history