Add linear interpolation methods. #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following PR adds a datastructure that represents a sparse volumetric grid. It allows for storing data in 3D. # TODO - [ ] Write unit tests - [ ] docs Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
This PR adds linear interpolation methods to the ignition math library these interpolation methods are needed for the VolumetricScalarGrid field,. Signed-off-by: Arjo Chakravarty <[email protected]>
chapulina
added
the
MBARI-LRAUV
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 99.90% 99.84% -0.07%
==========================================
Files 46 49 +3
Lines 4260 4396 +136
==========================================
+ Hits 4256 4389 +133
- Misses 4 7 +3
Continue to review full report at Codecov.
|
This was referenced Apr 19, 2022
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
hidmic
reviewed
Apr 25, 2022
hidmic
reviewed
Apr 25, 2022
Signed-off-by: Arjo Chakravarty <[email protected]>
…robotics/ign-math into arjo/feat/interpolation
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
hidmic
approved these changes
Apr 26, 2022
| /// interpolation. | ||
| public: std::vector<InterpolationPoint1D<T>> GetInterpolators( | ||
| const T &_value, | ||
| double _tol = 1e-6) const |
There was a problem hiding this comment.
@arjo129 should _tol be of type T?
| // Out of range | ||
| return {}; | ||
| } | ||
| else if (fabs(it->first - _value) < _tol) |
There was a problem hiding this comment.
@arjo129 nit^N!: if we use abs instead of fabs, including an using std::abs; statement before the if-else clause, T can be any numeric value, not just float and double.
|
CI failures seem unrelated. We are lacking some test coverage on VolumetricGridLookupField.hh though. |
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
This PR adds linear interpolation methods to the ignition math library these interpolation methods are needed for the VolumetricScalarGrid field,.
Signed-off-by: Arjo Chakravarty [email protected]
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.