Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-math7 #409

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

methylDragon
Copy link
Contributor

Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 13, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI and the links fixed

Ubuntu Focal | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_math-ci-ign-math6-focal-amd64)](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-focal-amd64)
Homebrew | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_math-ci-ign-math6-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-homebrew-amd64)
Windows | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_math-ci-ign-math6-windows7-amd64)](https://build.osrfoundation.org/job/ignition_math-ci-ign-math6-windows7-amd64)
Test coverage | [![codecov](https://codecov.io/gh/ignitionrobotics/ign-math/branch/ign-math7/graph/badge.svg)](https://codecov.io/gh/ignitionrobotics/ign-math)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh here too we should have caught this earlier. It's all main for the badges

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alright, once all the PRs are in, I can do a sweeping regex find and replace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming that every badge everywhere is main?

Copy link
Contributor

@chapulina chapulina Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every package's main branch should be using main links, yup. Thanks!

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #409 (25c9799) into main (4b84b98) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   99.73%   99.90%   +0.17%     
==========================================
  Files          70       46      -24     
  Lines        6419     4260    -2159     
==========================================
- Hits         6402     4256    -2146     
+ Misses         17        4      -13     
Impacted Files Coverage Δ
include/ignition/math/Cylinder.hh
src/DiffDriveOdometry.cc
include/ignition/math/Region3.hh
...e/ignition/math/AdditivelySeparableScalarField3.hh
include/ignition/math/detail/Sphere.hh
include/ignition/math/graph/Vertex.hh
include/ignition/math/OrientedBox.hh
eigen3/include/ignition/math/eigen3/Conversions.hh
src/Temperature.cc
include/ignition/math/MovingWindowFilter.hh
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b84b98...25c9799. Read the comment docs.

@chapulina
Copy link
Contributor

CI is all 🟢 !

@methylDragon methylDragon merged commit 75bfa63 into main Apr 13, 2022
@methylDragon methylDragon deleted the ci_matching_branch/bump_garden_ign-math7 branch April 13, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants