Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ellipsoid Python interface #404

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 5, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added Ellipsoid Python interface. Required by sdformat Python bindings

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 5, 2022
@ahcorde ahcorde requested a review from azeey April 5, 2022 16:23
@ahcorde ahcorde requested a review from scpeters as a code owner April 5, 2022 16:23
@ahcorde ahcorde self-assigned this Apr 5, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 5, 2022
Signed-off-by: ahcorde <[email protected]>
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #404 (0fcaa53) into ign-math6 (5fb0bce) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ign-math6     #404   +/-   ##
==========================================
  Coverage      99.65%   99.65%           
==========================================
  Files             67       67           
  Lines           6392     6392           
==========================================
  Hits            6370     6370           
  Misses            22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fb0bce...0fcaa53. Read the comment docs.

@ahcorde ahcorde merged commit c08c659 into ign-math6 Apr 8, 2022
@ahcorde ahcorde deleted the ahcorde/python/ellipsoid branch April 8, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants