Reduce memory required to compile pybind11 interface #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of headers included in the _ignition_math_pybind11.cc translation unit. Signed-off-by: Steve Peters <[email protected]>
This isolates the template code into its own translation unit. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## ign-math6 #371 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6380 6380
==========================================
Hits 6358 6358
Misses 22 22 Continue to review full report at Codecov.
|
chapulina
approved these changes
Jan 27, 2022
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
We observed some instances of ign-math6 CI jobs failing due to running out of memory during compilation of the pybind11 interfaces. This is a prototype for how to reduce memory usage.
Summary
Currently all pybind11 template interfaces are compiled in the same translation unit in _ignition_math_pybind11.cc. It is hypothesized that this contributes to the substantial memory consumption. This pull request provides a prototype of how to reduce that memory consumption by moving the template instantiations from
_ignition_math_pybind11.ccto a separate translation unitVector2.cc. Thanks to @sloretz for suggesting the approach.I also made a minor change in 62b65e0 that reduces the number of header files indirectly included by
_ignition_math_pybind11.cc. This may not be impactful but is easy to do.We can repeat this approach for the remaining files in a follow-up pull request if it is approved.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.