Added AxisAlignedBox pybind11 interface #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #338 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6360 6364 +4
==========================================
+ Hits 6338 6342 +4
Misses 22 22
Continue to review full report at Codecov.
|
chapulina
reviewed
Dec 27, 2021
| ////////////////////////////////////////////////// | ||
| AxisAlignedBox AxisAlignedBox::operator-(const Vector3d &_v) const | ||
| { | ||
| return AxisAlignedBox(this->dataPtr->min - _v, this->dataPtr->max - _v); |
There was a problem hiding this comment.
The coverage is decreasing, we should add tests for the new functions
chapulina
added
Gazebo 1️1️
Signed-off-by: Alejandro Hernández <[email protected]>
…ignitionrobotics/ign-math into ahcorde/pybind11/axisAlignedbox
chapulina
approved these changes
Dec 28, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR creates a AxisAlignedBox Pybind11 interface
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.