Added Angle Pybind11 interface #311
Conversation
Signed-off-by: ahcorde <[email protected]>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## ign-math6 #311 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6360 6360
==========================================
Hits 6338 6338
Misses 22 22 Continue to review full report at Codecov.
|
| @@ -62,6 +67,7 @@ if (${pybind11_FOUND}) | |||
| if (BUILD_TESTING) | |||
| # Add the Python tests | |||
| set(python_tests | |||
| Angle_TEST | |||
There was a problem hiding this comment.
I don't see these tests running on CI 🕵️♀️
There was a problem hiding this comment.
This might happens on Bionic. We at least require pybind11 2.2, but Bionic installs 2.0.1-4 Get:20 http://archive.ubuntu.com/ubuntu bionic/universe amd64 python3-pybind11 all 2.0.1-4 [4652 B]
Focal is fine https://github.com/ignitionrobotics/ign-math/runs/4559329091?check_suite_focus=true
maybe pip could fix this issue, I will check it
There was a problem hiding this comment.
Ah gotcha, thanks! I wouldn't worry about Bionic, targeting Focal is fine!
Signed-off-by: ahcorde <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
This PR creates a Angle Pybind11 interface
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.