-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example and modify document for class Color #304
Conversation
Signed-off-by: youhy <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-math6 #304 +/- ##
==========================================
Coverage 99.65% 99.65%
==========================================
Files 67 67
Lines 6359 6359
==========================================
Hits 6337 6337
Misses 22 22
Continue to review full report at Codecov.
|
Thank you for your contribution! |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Update Document
Add an example for class Color as one goal mentioned in #300
Summary
Add an example for class Color and change the existing documents.
Test it
Others
I found something weird about the
ignition::math::Color::HSV()
andignition::math::Color::SetFromHSV()
when writing the example. When using the return value of theHSV()
as the input forSetFromHSV()
, the value of the instance is inconsistent. But I am not sure if it is a bug or I'm just using it the wrong way so I am not sure if making it a separate issue is a good idea.Like this (put it in /example)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge