Use ImplPtr from ign-utils where relevant #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azeey
reviewed
Dec 9, 2021
azeey
reviewed
Dec 9, 2021
|
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
main_implptr
branch
from
e96a2e8
to
b59f8e2
Compare
|
I've added an ignition-math7 formula in osrf/homebrew-simulation#1727, so it should be easy now to add ignition-utils as a dependency |
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 99.53% 99.64% +0.10%
==========================================
Files 68 65 -3
Lines 6275 6131 -144
==========================================
- Hits 6246 6109 -137
+ Misses 29 22 -7
Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
|
@scpeters this is ready for another look |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
main_implptr
branch
from
1bffd38
to
15e65e3
Compare
Signed-off-by: Michael Carroll <[email protected]>
scpeters
changed the title
chapulina
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
We are introducing ign-utils as a dependency, so it seems like a reasonable to to switch to ImplPtr where relevant. I have done this for everything except for what is covered by #294
Note to maintainers: Remember to use Squash-Merge