Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping on the
math::Pair
unittest.I'm not sure that exhaustively testing this many pairs is worthwhile, in general.
On my system (before):
(after):
I believe that @nkoenig and @scpeters were the ones who most recently touched this function, so pinging them for reviews.
Signed-off-by: Michael Carroll [email protected]
Note to maintainers: Remember to use Squash-Merge