Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quaternion_from_euler example: input degrees #282

Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Improve units in example program

Summary

It's easier to specify angles in degrees than radians, so change this example to accept user input in degrees.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

It's easier to specify angles in degrees than radians,
so change this example to accept user input in degrees.

Signed-off-by: Steve Peters <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #282 (72d0cb2) into ign-math6 (884d67f) will not change coverage.
The diff coverage is n/a.

❗ Current head 72d0cb2 differs from pull request most recent head 83fa2da. Consider uploading reports for the commit 83fa2da to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #282   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884d67f...83fa2da. Read the comment docs.

@scpeters scpeters merged commit 919b511 into gazebosim:ign-math6 Nov 10, 2021
@scpeters scpeters deleted the quaternion_from_euler_degrees branch November 10, 2021 22:25
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants