Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal URL fixed (paragraph 266) #279

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

kant
Copy link
Contributor

@kant kant commented Oct 30, 2021

🦟 Bug fix

No Fixes any previous PR

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Darío Hereñú [email protected]

@kant kant requested a review from scpeters as a code owner October 30, 2021 00:49
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 30, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! Can you sign your commit for the DCO checker?

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #279 (587ed01) into ign-math6 (200a7ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 587ed01 differs from pull request most recent head 2316d22. Consider uploading reports for the commit 2316d22 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #279   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6374     6374           
==========================================
  Hits            6337     6337           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200a7ff...2316d22. Read the comment docs.

@ahcorde
Copy link
Contributor

ahcorde commented Nov 2, 2021

friendly ping @kant

@kant kant force-pushed the patch-1 branch 2 times, most recently from 47abc81 to 2e8faa7 Compare November 2, 2021 20:42
@ahcorde
Copy link
Contributor

ahcorde commented Nov 4, 2021

@kant the DCO is still failing. You can try this:

git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1

@kant
Copy link
Contributor Author

kant commented Nov 4, 2021

@kant the DCO is still failing. You can try this:

git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1

After the last script git push -f origin patch-1
the prompt alerts me this:

error: src refspec patch-1 does not match any
error: failed to push some refs to 'https://github.com/kant/ign-math.git'

Appended to original pull request according https://ignitionrobotics.org/docs/all/contributing#process
Signed-off-by: Darío Hereñú [email protected]

@ahcorde
Copy link
Contributor

ahcorde commented Nov 5, 2021

@kant ,

did you fetch your repo and checkout the right branch?

git clone https://github.com/kant/ign-math
cd ign-math
git checkout patch-1
git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1

@ahcorde
Copy link
Contributor

ahcorde commented Nov 8, 2021

@kant, did you try the last suggestion?

Signed-off-by: Darío Hereñú <[email protected]>
@kant
Copy link
Contributor Author

kant commented Nov 9, 2021

Done! (following this procedures:

cd ign-math
git checkout patch-1
git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1

@chapulina
Copy link
Contributor

Thanks again, @kant !

@chapulina chapulina merged commit f92b793 into gazebosim:ign-math6 Nov 9, 2021
@kant
Copy link
Contributor Author

kant commented Nov 9, 2021

Thanks for sharing your knowledge. It is a pleasure to contribute to this project. Kudos and thanks for your patience @ahcorde @chapulina @scpeters @clalancette !!

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants