-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal URL fixed (paragraph 266) #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks! Can you sign your commit for the DCO checker?
Codecov Report
@@ Coverage Diff @@
## ign-math6 #279 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6374 6374
==========================================
Hits 6337 6337
Misses 37 37 Continue to review full report at Codecov.
|
friendly ping @kant |
47abc81
to
2e8faa7
Compare
@kant the DCO is still failing. You can try this: git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1 |
After the last script
Appended to original pull request according https://ignitionrobotics.org/docs/all/contributing#process |
@kant , did you fetch your repo and checkout the right branch? git clone https://github.com/kant/ign-math
cd ign-math
git checkout patch-1
git reset --hard HEAD~2
git commit --amend --no-edit --signoff
git push -f origin patch-1 |
@kant, did you try the last suggestion? |
Signed-off-by: Darío Hereñú <[email protected]>
Done! (following this procedures:
|
Thanks again, @kant ! |
Thanks for sharing your knowledge. It is a pleasure to contribute to this project. Kudos and thanks for your patience @ahcorde @chapulina @scpeters @clalancette !! |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
No Fixes any previous PR
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
Signed-off-by: Darío Hereñú [email protected]