Plane Python interfaces #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
github-actions
bot
added
Gazebo 1️1️
This was referenced Oct 29, 2021
Merged
Codecov Report
@@ Coverage Diff @@
## ign-math6 #272 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6374 6374
==========================================
Hits 6337 6337
Misses 37 37 Continue to review full report at Codecov.
|
This was referenced Oct 29, 2021
Merged
scpeters
reviewed
Oct 29, 2021
src/python/Plane_TEST.py
Outdated
| def test_plane_constructor(self): | ||
| plane = Planed(Vector3d(1, 0, 0), 0.1) | ||
| self.assertEqual(plane.normal(), Vector3d(1, 0, 0)) | ||
| # self.assertAlmostEqual(plane.offset(), 0.1, 1e-6) |
There was a problem hiding this comment.
was there a problem with this expectation?
Signed-off-by: Steve Peters <[email protected]>
scpeters
approved these changes
Oct 30, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
Added Plane Python interface.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge