Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pose3_TEST.py: use 0.01 (not 0) in string test #257

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

scpeters
Copy link
Member

🦟 Bug fix

I believe this fixes #250

Summary

Pose3_TEST.py is failing on arm64 due to a -0 instead of 0 in an expected string. This changes the constant from 0 to 0.01 to workaround the ambiguity.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 30, 2021
Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

I'm going to try a prerelease directly from this branch

@j-rivero
Copy link
Contributor

Pose3_TEST.py is failing on arm64 due to a -0 instead of 0 in an expected string. This changes the constant from 0 to 0.01 to workaround the ambiguity.

The hypothesis could be right. +1, let's see how it goes the debbuilder.

@scpeters
Copy link
Member Author

I'm going to try a prerelease directly from this branch

Build Status https://build.osrfoundation.org/job/ign-math6-debbuilder/1114/

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #257 (334dc09) into ign-math6 (6253662) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #257   +/-   ##
==========================================
  Coverage      99.41%   99.41%           
==========================================
  Files             67       67           
  Lines           6347     6347           
==========================================
  Hits            6310     6310           
  Misses            37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6253662...334dc09. Read the comment docs.

@j-rivero
Copy link
Contributor

seems good! Build Status

@scpeters scpeters merged commit a721b6d into gazebosim:ign-math6 Sep 30, 2021
@scpeters scpeters deleted the py_pose3_test_nonzero branch September 30, 2021 23:04
mjcarroll added a commit that referenced this pull request Oct 13, 2023
Fixes #257

Signed-off-by: Michael Carroll <[email protected]>
mjcarroll added a commit that referenced this pull request Oct 13, 2023
Fixes #257

Signed-off-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pose3_TEST.py fails in arm64 6.9.0~pre1
3 participants